Ambros

Results 12 comments of Ambros

Hi, I would like to work on this issue, but I am stuck on choosing the right Monad `m` for the `LogAction m msg`. After some trying around I came...

Looks like this will be solved soon: https://github.com/arybczak/effectful/issues/52 I will use this new class as the `Subset` class I proposed.

Thanks for the feedback. You are right, this does not work as I expected, the `logEffects` would be ambiguous.

Adding the constraint `contiguous == 0.5.2` for ghc-8.8.4 should fix the build issue. But I am not sure how to add it only to 8.8.4.

I think I messed up something while implementing the Concurrent Effects. Running the `withBackgroundLogger/logs all messages concurrently" test results in an access violation: ``` Access violation in generated code when...

@mmhat Thanks for all the help! I hope I have not cause you too much trouble. Please let me know if further changes are required. How are maintainers and other...

@arybczak Thanks for the help. Yes, I don't understand enough about the library internals to evaluate whether this implementation is sound or not. I more or less just tried around...

I know that the difference for logging is probably very small, however if there is no real gain in implementing the dynamic version then why not choose the static version?...

@mmhat Thanks for the reminder and the suggestions. Yes this does sound reasonable. I will implement these changes as soon as possible.

I think these commits should cover all changes. I am not sure how you would like to handle moving this to the new Project, I made a [new branch](https://github.com/ambroslins/effectful-contrib/tree/co-log-static) with...