recaptcha icon indicating copy to clipboard operation
recaptcha copied to clipboard

recaptcha v3 does not work in MSIE 11

Open jirihradil opened this issue 5 years ago • 9 comments

Hi,

we're facing an issue with recaptcha v3 in Microsoft Internet Explorer 11 (default configuration, no plugins, clean installation with Windows 10, version 11.615.17763.0).

Recaptcha token is not fetched because of JS errors/double rendered ending script tag - please see the screenshots attached.

We use common helper attributes, not playing with JS generation/callbacks/scripts etc.

<%= recaptcha_v3(action: 'login', hl: I18n.locale, site_key: 'oursitekey') %>

In all other browsers (Chrome, Opera, Firefox) we don't have any issues at all. Unfortunately, a lot of our clients still use MSIE and we cannot switch them.

I didn't find any information that reCaptcha v3 should not work in MSIE 11, so could it be a gem's JS script issue?

Anyway, thanks for the awesome gem!

Screenshot (3) Screenshot (4) Screenshot (5)

jirihradil avatar Aug 27 '19 08:08 jirihradil

Can you bundle open recaptcha and delete js until the error goes away ? ... the double closing looks weird ...

On Tue, Aug 27, 2019 at 1:30 AM Jiri Hradil [email protected] wrote:

Hi,

we're facing an issue with recaptcha v3 in Microsoft Internet Explorer 11 (default configuration, no plugins, clean installation with Windows 10, version 11.615.17763.0).

Recaptcha token is not fetched because of JS errors/double rendered ending script tag - please see the screenshots attached.

We use common helper attributes, not playing with JS generation/callbacks/scripts etc.

<%= recaptcha_v3(action: 'login', hl: I18n.locale, site_key: 'oursitekey') %>

In all other browsers (Chrome, Opera, Firefox) we don't have any issues at all. Unfortunately, a lot of our clients still use MSIE and we cannot switch them.

I didn't find any information that reCaptcha v3 should not work in MSIE 11, so could it be a gem's JS script issue?

Anyway, thanks for the awesome gem!

[image: Screenshot (3)] https://user-images.githubusercontent.com/656029/63754656-8a833080-c8b5-11e9-9ce3-775181e3f93f.png [image: Screenshot (4)] https://user-images.githubusercontent.com/656029/63754653-89ea9a00-c8b5-11e9-93aa-918f01946835.png [image: Screenshot (5)] https://user-images.githubusercontent.com/656029/63754654-89ea9a00-c8b5-11e9-9d1c-618350931086.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ambethia/recaptcha/issues/332?email_source=notifications&email_token=AAACYZZWNBT77EB4KYFNK5LQGTQ2TA5CNFSM4IQALOIKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HHSUVMA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAACYZZBVZVMDMTNB2TYZBLQGTQ2TANCNFSM4IQALOIA .

grosser avatar Aug 27 '19 14:08 grosser

Sorry, don't get it. Yes, I can delete JS in the source code which causes the problem but then the captcha will stop working, won't it? :) I tried it again in the simplest possible example and I can say that the gem is not working in MSIE 11 :(

jirihradil avatar Aug 27 '19 20:08 jirihradil

Delete source code until the error goes away, to see what part exactly causes the error ... then try to improve that part.

On Tue, Aug 27, 2019 at 1:09 PM Jiri Hradil [email protected] wrote:

Sorry, don't get it. Yes, I can delete JS in the source code which causes the problem but then the captcha will stop working, won't it? :) I tried it again in the simplest possible example and I can say that the gem is not working in MSIE 11 :(

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ambethia/recaptcha/issues/332?email_source=notifications&email_token=AAACYZ2ROP37IRVHOL6ECSLQGWCY5A5CNFSM4IQALOIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5I6Z4Y#issuecomment-525462771, or mute the thread https://github.com/notifications/unsubscribe-auth/AAACYZYSCPQRZAJPEC66FE3QGWCY5ANCNFSM4IQALOIA .

grosser avatar Aug 27 '19 22:08 grosser

I "improved that part" by implementing captcha v3 manually because I found the current code over-complicated. Here is how to do that:

https://dev.to/morinoko/adding-recaptcha-v3-to-a-rails-app-without-a-gem-46jj

The code from the link (which is just a follow-up of Google reCAPTCHA docs) works perfectly in MSIE.

jirihradil avatar Aug 31 '19 19:08 jirihradil

looks good! :)

On Sat, Aug 31, 2019 at 12:44 PM Jiri Hradil [email protected] wrote:

I "improved that part" by implementing captcha v3 manually because I found the current code over-complicated. Here is how to do that:

https://dev.to/morinoko/adding-recaptcha-v3-to-a-rails-app-without-a-gem-46jj

The code from the link (which is just a follow-up of Google reCAPTCHA docs) works perfectly in MSIE.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ambethia/recaptcha/issues/332?email_source=notifications&email_token=AAACYZ6MHE6D63ZJINGC2SLQHLC2RA5CNFSM4IQALOIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5TT7WA#issuecomment-526860248, or mute the thread https://github.com/notifications/unsubscribe-auth/AAACYZ2OXWTQJBJUIXCSG4DQHLC2RANCNFSM4IQALOIA .

grosser avatar Aug 31 '19 21:08 grosser

This has to do with async not being supported in IE11. I created a fork that should fix this.

thomasbrus avatar Jan 31 '20 11:01 thomasbrus

with IE changing to chromium, this should be fixed soon, right ?

grosser avatar Jan 31 '20 12:01 grosser

@grosser I don't think so 😅 IE11 is no longer being updated afaik. async/await already works in newer versions of IE/Edge though (see https://caniuse.com/#search=async)

thomasbrus avatar Jan 31 '20 12:01 thomasbrus

good to know :)

On Fri, Jan 31, 2020 at 1:14 PM Thomas Brus [email protected] wrote:

@grosser https://github.com/grosser I don't think so 😅 IE11 is no longer being updated afaik. async/await already works in newer versions of IE/Edge though (see https://caniuse.com/#search=async)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ambethia/recaptcha/issues/332?email_source=notifications&email_token=AAACYZ4LCDI5ULUIH4CNE43RAQIY5A5CNFSM4IQALOIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKOO6AY#issuecomment-580710147, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACYZ6DLKXRHUFIMPNFE3DRAQIY5ANCNFSM4IQALOIA .

grosser avatar Jan 31 '20 12:01 grosser