amber
amber copied to clipboard
`amber g ` creates system tests that are incomplete for controller/request testing
When using the api generator like:
amber g api examplething name:string
Everything generates properly, however when you run the tests you'll get errors like:
response = subject.get "/examplething"
This is because the GarnetSpec::RequestHelper isn't being included in the controller test class that is being generated.
This is definitely being missed in our test coverage as well.
- Fix the generators to ensure everything generating a system/controller test is including the necessary module.
- Add test coverage to check that everything is being included in the generator files.
- Add a workflow to CircleCI that creates an amber app and then runs the generator and runs the spec suite. Everything for a brand new app should run without issue.