amber icon indicating copy to clipboard operation
amber copied to clipboard

flash.now doesn't work and isn't consistent with documentation

Open rmarronnier opened this issue 6 years ago • 3 comments

https://docs.amberframework.org/amber/guides/controllers/flash#flash-now

Calling flash.now["blabla"] gives a compile error : 'undefined method 'now' for Hash(String, String)'

Calling flash.now "key", "value" compiles but doesn't do anything and nothing gets returned in the logs

Versions

Amber CLI (amberframework.org) - v0.11.3 Crystal 0.27.2 [60760a546] (2019-02-05)

LLVM: 4.0.0 Default target: x86_64-unknown-linux-gnu

Thanks for this wonderful framework anyway !

rmarronnier avatar Feb 26 '19 20:02 rmarronnier

Is this still an issue for you in the latest release of Amber and Crystal?

elaine-jackson avatar May 07 '19 20:05 elaine-jackson

@nsuchy @rmarronnier if you would like to open a PR addressing this issue please feel free.

eliasjpr avatar Sep 12 '19 17:09 eliasjpr

I'll look at this, this week-end and make a tentative PR

rmarronnier avatar Sep 13 '19 13:09 rmarronnier