ion-js

ion-js copied to clipboard

When reading a binary Ion file with invalid values for the components, ion-js does not throw an error. ```javascript let timestampBinary = [ // bvm 224, 1, 0, 234, //...

jonwilsdon

We are only testing it with integration tests, not ideal.

wesboyt

Update the [Cookbook](https://amzn.github.io/ion-docs/guides/cookbook.html) so the ion-js examples can be executed within the browser. I'd suggest we do this sometime after use of the library within a browser is officially supported.

pbcornell

Better documentation of implementation structure

2

- UML diagram documenting interaction of files/objects/methods within the codebase. - Refactoring inheritance using JS equivalents of "Interfaces/classes" to allow typescript to ensure the contracts detailed in the UML. This...

wesboyt

Consistent interface for reading annotations

1

Currently `IonTextReader` exposes annotations via `.annotations()` (returns an Array), whereas `IonBinaryReader` exposes annotations via `hasAnnotations()` and `getAnnotation(i)` (returns the annotation at a specific index in the array). Can these be...

mtcalvin

integrate with the cross-language consensus test harness

1

As testing harness spec is fleshed out IonJS needs to be kept abreast of the necessary endpoints/logic to support interoperability in the future.

wesboyt

Currently the js library cannot statically compile due to numerous typing errors around unidentified reference error handling.

wesboyt

Loading ion-js breaks standard Webpack build

4

I'm trying to include ion-js in a project that uses a standard webpack build (create-react-app): ```javascript import { makeReader } from 'ion-js'; console.log('Hello world!'); ``` [See the full repo here](https://github.com/cimi/ion-js-webpack),...

cimi

SymbolTokens

2

SymbolTokens and import descriptors will need to be implemented.

wesboyt

bad files that pass

1

- /home/travis/build/amzn/ion-js/ion-tests/iontestdata/bad/timestamp/timestampHourWithoutMinute.10n - /home/travis/build/amzn/ion-js/ion-tests/iontestdata/bad/structOrderedEmpty.10n - /home/travis/build/amzn/ion-js/ion-tests/iontestdata/bad/stringLenTooLarge.10n - /home/travis/build/amzn/ion-js/ion-tests/iontestdata/bad/nopPadWithAnnotations.10n - /home/travis/build/amzn/ion-js/ion-tests/iontestdata/bad/negativeIntZeroLn.10n - /home/travis/build/amzn/ion-js/ion-tests/iontestdata/bad/negativeIntZero.10n - /home/travis/build/amzn/ion-js/ion-tests/iontestdata/bad/minLongWithLenTooLarge.10n

wesboyt