ion-js

ion-js copied to clipboard

Lists, s-exp and structs * ion-tests/iontestdata/good/typecodes/T11.10n * ion-tests/iontestdata/good/typecodes/T12.10n * ion-tests/iontestdata/good/typecodes/T13.10n

raganhan

http://amzn.github.io/ion-docs/docs/binary.html#6-timestamp

raganhan

http://amzn.github.io/ion-docs/docs/binary.html#2-and-3-int

raganhan

see T1-bool https://github.com/amzn/ion-tests/blob/master/iontestdata/bad/typecodes/README.md

raganhan

http://amzn.github.io/ion-docs/docs/binary.html#15-reserved

raganhan

See https://github.com/amzn/ion-tests/commit/48a63157b28b81ed72c71789dac7d7f0ffe87038#diff-213037c0103f43ac80f202a7849105f6

raganhan

See * https://github.com/amzn/ion-tests/blob/master/iontestdata/good/typecodes/T7-small.10n * https://github.com/amzn/ion-tests/blob/master/iontestdata/good/typecodes/T7-large.10n

raganhan

There is some cleanup work to be done with how ion-js validates binary Ion type descriptors that came out of amzn/ion-tests#57 when testing the ion-tests/iontestdata/bad/typecodes/*.10n files: * _type\_1\_length\_*.10n_ (`0x1_`) does...

jonwilsdon

While testing the edges of https://github.com/amzn/ion-tests/pull/57, I discovered that `reader.booleanValue()` can be called on any value below `0x10` (it returns `null` on non-boolean values). For values above `0x1F` it produces...

jonwilsdon

IonDecimal returns float representation in toString()

1

This issue surfaced in the comments over in amzn/ion-tests: https://github.com/amzn/ion-tests/pull/56#discussion_r362615558. IonDecimal `toString()` returns values with an 'E' (https://github.com/amzn/ion-js/blob/master/src/IonDecimal.ts#L227) that are only valid for floats. The IonTextWriter properly writes out a...

jonwilsdon