amazon-braket-sdk-python icon indicating copy to clipboard operation
amazon-braket-sdk-python copied to clipboard
verified publisher icon amazon-braket

Patch 1

Open himanshu007-creator opened this issue 4 years ago • 5 comments

Issue #, if available: #271

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [ ] I have read the CONTRIBUTING doc
  • [ ] I used the commit message format described in CONTRIBUTING
  • [ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [ ] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

himanshu007-creator avatar Sep 16 '21 13:09 himanshu007-creator

Hello and thank you for your pull request. Would you please update the commit message and pull request message to have some information related to the change? Also some of the checks are failing. Locally, you can run tox in the package path to see the trace.

AbeCoull avatar Sep 16 '21 16:09 AbeCoull

Hello and thank you for your pull request. Would you please update the commit message and pull request message to have some information related to the change? Also some of the checks are failing. Locally, you can run tox in the package path to see the trace.

okay, I will make the required changes.

himanshu007-creator avatar Sep 17 '21 07:09 himanshu007-creator

Hello @himanshu007-creator! Checking in to see if you are you still planning on updating this PR.

kshitijc avatar Feb 08 '22 19:02 kshitijc

Hello @himanshu007-creator! Checking in to see if you are you still planning on updating this PR.

Hi, i am working on this , but could'nt do it. Please help me for these changes. Thanks

himanshu007-creator avatar Feb 11 '22 16:02 himanshu007-creator

Hello @himanshu007-creator! Checking in to see if you are you still planning on updating this PR.

Hi, i am working on this , but could'nt do it. Please help me for these changes. Thanks

Could you please describe what you're stuck on, so that we can help you here ?

kshitijc avatar Feb 21 '22 16:02 kshitijc

Closing since there have been no updates on this PR. Please feel free to reopen if you wish to make changes.

kshitijc avatar Dec 06 '22 17:12 kshitijc