amazon-braket-sdk-python icon indicating copy to clipboard operation
amazon-braket-sdk-python copied to clipboard

infra: drop support for Python 3.9

Open AbeCoull opened this issue 1 year ago • 3 comments

Issue #, if available:

Description of changes: This PR serves to allow Braket to start dropping support for Python 3.10. Dependencies have begun to do so. This does not serve as an immediate action but a look into what changes would take place to achieve dropped support.

Notable packages:

  • https://github.com/numpy/numpy/releases/tag/v2.1.1
  • https://github.com/PennyLaneAI/pennylane/commit/713a33d490326976c3c6efb81ddc7adc6385d88c (this is expected in their next Pypi release)
  • https://github.com/scipy/scipy/releases/tag/v1.14.0
  • https://github.com/google/jax/releases/tag/jax-v0.4.31

I have added comments within https://github.com/amazon-braket/amazon-braket-examples/blob/main/requirements.txt to highlight these during dependency upgrades.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [ ] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AbeCoull avatar Sep 06 '24 23:09 AbeCoull

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (e4e0c9f) to head (939c053).

Additional details and impacted files
@@             Coverage Diff             @@
##           ruff_test     #1031   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files            135       135           
  Lines           8998      8989    -9     
  Branches        2020      2020           
===========================================
- Hits            8998      8989    -9     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 06 '24 23:09 codecov[bot]

@math411 Could you provide some more background/context on why we want to do this, given that Python 3.9 is not EOL until October 2025?

rmshaffer avatar Sep 18 '24 18:09 rmshaffer

@rmshaffer added in some context.

AbeCoull avatar Sep 18 '24 18:09 AbeCoull

Too many conflicts - started anew in https://github.com/amazon-braket/amazon-braket-sdk-python/pull/1077

AbeCoull avatar Apr 24 '25 03:04 AbeCoull