amazon-braket-examples icon indicating copy to clipboard operation
amazon-braket-examples copied to clipboard

update: example directory cleanup

Open michaab opened this issue 2 years ago • 1 comments

Issue #, if available:

Description of changes:

  1. Rename folders to expand acronyms and clarify terms
  2. Use local simulator instead of sv1 to reduce cost in several notebooks
  3. Change managed simulator language to on-demand
  4. Fix broken links
  5. Remove unneeded pip freeze command

Testing:

  • Ran and validated notebooks with functional changes.
  • Validated previously broken links work properly.
  • Validated text only changes by opening notebooks.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

michaab avatar Oct 13 '22 19:10 michaab

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Did we also decide on renaming the qchem folder to Hydrogen Geometry?

virajvchaudhari avatar Oct 18 '22 05:10 virajvchaudhari

Can we also validate whether this affect the docs in SDK too; unfortunately, everything there is hardcoded. And also in the developer docs

virajvchaudhari avatar Oct 27 '22 16:10 virajvchaudhari

Can we also validate whether this affect the docs in SDK too; unfortunately, everything there is hardcoded. And also in the developer docs

Adding - it is probably worth checking that this doesn't break old console announcements / redirecting those as required

ajberdy avatar Oct 27 '22 17:10 ajberdy

Can we also validate whether this affect the docs in SDK too; unfortunately, everything there is hardcoded. And also in the developer docs

I've verified no links need to be updated in the developer docs. The SDK will have a couple links that I'll update in a separate PR, right after this PR

michaab avatar Nov 01 '22 17:11 michaab

Can we also validate whether this affect the docs in SDK too; unfortunately, everything there is hardcoded. And also in the developer docs

Adding - it is probably worth checking that this doesn't break old console announcements / redirecting those as required

Good callout to check this! I validated the old console announcements are not impacted by these changes either.

michaab avatar Nov 01 '22 17:11 michaab