amazon-braket-examples icon indicating copy to clipboard operation
amazon-braket-examples copied to clipboard

add deutsch jozsa algorithm

Open tanishabassan opened this issue 2 years ago • 6 comments

Issue #, if available:

Description of changes: Adding the Deutsch-Jozsa Algorithm example notebook.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

tanishabassan avatar Aug 03 '22 18:08 tanishabassan

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

General comment: the notebook should be a mix of code and exposition, rather than just code is it currently is. For example take a look at the superdense coding and Simon's algorithm notebooks. They have many Markdown cells including background, explanations of steps, and diagrams.

speller26 avatar Aug 03 '22 20:08 speller26

General comment: the notebook should be a mix of code and exposition, rather than just code is it currently is. For example take a look at the superdense coding and Simon's algorithm notebooks. They have many Markdown cells including background, explanations of steps, and diagrams.

Hi Cody! Yes that's my next task, I'll be adding markdown to support my code and adding to my PR.

tanishabassan avatar Aug 03 '22 20:08 tanishabassan

I would like to see some markdown discussion in between the code cells. It's helpful to set up what's about to happen preceding some action, then discuss / reflect on the outcome in the markdown cell after some code is executed.

aaronmarkham avatar Aug 10 '22 19:08 aaronmarkham

Thanks for the updated PR, Tanisha. While Braket notebooks don't have to conform to SageMaker's, there are some best practices to be found in the SageMaker notebooks template. Most notably, I was wondering if there's any cleanup of resources to be done at the end. And how about any references? Is there a recommended next tutorial after this one?

Added some resources at the end of the tutorial and referenced a textbook from where I learnt a lot about the algorithm.

tanishabassan avatar Aug 25 '22 17:08 tanishabassan

I would like to see some markdown discussion in between the code cells. It's helpful to set up what's about to happen preceding some action, then discuss / reflect on the outcome in the markdown cell after some code is executed.

Implemented in most recent PR

tanishabassan avatar Aug 25 '22 17:08 tanishabassan