amazon-braket-default-simulator-python icon indicating copy to clipboard operation
amazon-braket-default-simulator-python copied to clipboard

feat: Make MAX_NET_DETUNING in AHS device capabilities optional and extend field validator utility functions.

Open Altanali opened this issue 1 year ago • 1 comments

Issue #, if available:

Description of changes: Make the MAX_NET_DETUNING device capability data point optional for AHS program validation - this is done so the Program validator used for AHS programs with the local simulator can also be used with capabilities derived from QPU capabilities, which don't provide a MAX_NET_DETUNING data point.

Additionally, utility methods validate_max_absolute_slope,validate_time_precision,validate_time_separation,validate_value_precision are added to field validator utilities for use AHS Program validation with Device Capabilities Constants (introduced in BDK).

Testing done: Tested the newly introduced field validation utility functions.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [x] I have read the CONTRIBUTING doc
  • [x] I used the commit message format described in CONTRIBUTING
  • [x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [x] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Altanali avatar Jul 27 '24 02:07 Altanali

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 100.00%. Comparing base (47ee03f) to head (3731450). :warning: Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #272   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         4141      4159   +18     
  Branches       429       437    +8     
=========================================
+ Hits          4141      4159   +18     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 27 '24 02:07 codecov[bot]