amazon-braket-default-simulator-python icon indicating copy to clipboard operation
amazon-braket-default-simulator-python copied to clipboard

feat: allow negative controlled global phase gate

Open jcjaskula-aws opened this issue 1 year ago • 2 comments

Issue #, if available: Negative controlled gphase are executable via a simple translation.

Description of changes: We provide the translation for negctrl @ gphase

Testing done: Added unit tests.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [ ] I have read the CONTRIBUTING doc
  • [ ] I used the commit message format described in CONTRIBUTING
  • [ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [ ] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jcjaskula-aws avatar Nov 30 '23 10:11 jcjaskula-aws

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (a9808f3) to head (211976b).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #216   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         3802      3810    +8     
  Branches       930       932    +2     
=========================================
+ Hits          3802      3810    +8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 30 '23 12:11 codecov[bot]

I wouldn't label this as a fix, as the previous implementation fit the spec. This is an extension of functionality

ajberdy avatar Nov 30 '23 21:11 ajberdy