aws-service-operator icon indicating copy to clipboard operation
aws-service-operator copied to clipboard

Configmaps for services other than s3 missing

Open jgryszko opened this issue 7 years ago • 5 comments

Is it planned to create config maps for other services than s3 (sqs, sns ...), or is there any reason, why it was omitted? Looking for areas to contribute...

jgryszko avatar Oct 23 '18 13:10 jgryszko

There is not a reason, this would be a great first issue :)

christopherhein avatar Oct 23 '18 15:10 christopherhein

@christopherhein Any update on this? I've tried to add corresponding additional resource to sqsqueue.yaml model and rebuild aws-service-operator but it still doesn't create configmap for sqs. Basically what I tried so far:

  additionalResources:
    configMaps:
    - name: sqsCM
      data:
      - key: queueARN
        value: "{{.Obj.Output.QueueARN}}"
      - key: queueName
        value: "{{.Obj.Output.QueueName}}"
      - key: queueURL
        value: "{{.Obj.Output.QueueURL}}"

and then run "make rebuld" to regenerate and build code. Am I miss something?

ivanich avatar Feb 10 '19 08:02 ivanich

Turned out it never used my edited code but used unmodified sources from vendor dir.

ivanich avatar Feb 12 '19 18:02 ivanich

Turned out it never used my edited code but used unmodified sources from vendor dir.

So you have it working?

christopherhein avatar Feb 12 '19 18:02 christopherhein

Turned out it never used my edited code but used unmodified sources from vendor dir.

So you have it working?

Yes, for some reason sources from vendor/github.com/awslabs/aws-service-operator/ was used. It would be nice to see configmap support for all resources in upstream as well as helm charts repo.

ivanich avatar Feb 12 '19 18:02 ivanich