aws-serverless-event-fork-pipelines icon indicating copy to clipboard operation
aws-serverless-event-fork-pipelines copied to clipboard

Encrypting all the storage resources

Open wolfeidau opened this issue 5 years ago • 2 comments

Just wanted to know if you had considered enabling encryption for all the data stored?

Specifically the:

  • SQS Queues
  • SNS Topics
  • S3 Buckets

wolfeidau avatar May 24 '19 01:05 wolfeidau

@wolfeidau Thanks for opening this issue! We did consider some compliance implications while building the apps, but you bring up good points here:

  1. SQS Queues - We could add an optional parameter to specify a KMS encryption key (could be default key or customer-managed key). If specified, we'd enable encryption on the SQS queue using the specified key.
  2. We could handle SNS topics similar to SQS queues.
  3. For S3 buckets, it depends on the app. We did consider this for the storage and backup app, but rather than adding encryption options to the app itself, we allowed the app to work with an existing S3 bucket. That way, you could configure the bucket however you want, rather than the app have to surface every possible option for S3 buckets. The search and analytics app does create an S3 bucket to use as a dead-letter queue for the Kinesis Firehose Delivery Stream. We may need to parameterize that as well to support encryption of that bucket.

Would these changes address your concerns?

jlhood avatar May 29 '19 19:05 jlhood

Starting with encryption at rest where possible would be great. My ticket was just about ensuring this application has sane defaults and calling this out in the README.

Most people who work in security sensitive areas will understand encryption at rest where possible as a baseline.

wolfeidau avatar Jun 02 '19 01:06 wolfeidau