amazon-quicksight-embedding-sample icon indicating copy to clipboard operation
amazon-quicksight-embedding-sample copied to clipboard

Upgrade deprecated runtime nodejs8.10

Open chriscoombs opened this issue 5 years ago • 2 comments

CloudFormation templates in amazon-quicksight-embedding-sample have been found to include a deprecated Lambda function runtime (nodejs8.10). The affected templates have been updated to a supported runtime (nodejs10.x).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

chriscoombs avatar Jan 08 '20 10:01 chriscoombs

How about pushing it all the way to nodejs12.x? I have tested this and it works fine.

jesperalmstrom avatar Jan 13 '20 19:01 jesperalmstrom

@jesperalmstrom the bot suggests nodejs10.x as it's currently the latest version of Node supported by Lambda@Edge. I've bumped the version to 12 manually. 😄

chriscoombs avatar Jan 14 '20 14:01 chriscoombs