react-mapbox-gl-draw icon indicating copy to clipboard operation
react-mapbox-gl-draw copied to clipboard

Example not working correctly (any more)

Open StefanoOcchetti opened this issue 2 years ago • 5 comments

The example is not running correctly any more.

  1. package.json
"example": "yarn build && cd example && webpack-dev-server",

should become:

"example": "yarn build && cd example && webpack serve",
  1. App.js

Controls are not shown. The following import is missing:

import 'mapbox-gl/dist/mapbox-gl.css';

StefanoOcchetti avatar Sep 01 '22 13:09 StefanoOcchetti

@StefanoOcchetti Thanks! Would you like to create a PR?

amaury1093 avatar Sep 01 '22 14:09 amaury1093

I'd love to... but I don't manage to push to a new branch... can you grant me new branch creation?

StefanoOcchetti avatar Sep 01 '22 14:09 StefanoOcchetti

You need to first fork the project, then push your branches to your fork (you have rights there), and the create a Pull Request from your fork to this repo.

amaury1093 avatar Sep 01 '22 14:09 amaury1093

yes, ok. I'll do that!

StefanoOcchetti avatar Sep 01 '22 14:09 StefanoOcchetti

https://github.com/amaurym/react-mapbox-gl-draw/pull/565

StefanoOcchetti avatar Sep 01 '22 15:09 StefanoOcchetti