react-credit-cards icon indicating copy to clipboard operation
react-credit-cards copied to clipboard

react@"18.0.0" support

Open ant1m4tt3r opened this issue 2 years ago • 3 comments

Hey! Can we add react@"18.0.0" as a supported version for this package? It seems to be working fine for me in this version, but I have to install it using npm i react-credit-cards --force. Without the --force flag it fails because of the peer dependency not allowing react-18.

If you guys approve the idea, I can make a quick PR and check if tests are still passing.

ant1m4tt3r avatar May 17 '22 14:05 ant1m4tt3r

Try react-credit-cards-2 mentioned at https://github.com/amaroteam/react-credit-cards/issues/115

felquis avatar Jun 27 '22 23:06 felquis

There are two PRs open right now that specifically upgrade the React dependency to 18 and are awaiting approval. https://github.com/amaroteam/react-credit-cards/pull/116 https://github.com/amaroteam/react-credit-cards/pull/117

@gilbarbara @cassiocardoso as the two biggest contributors in the past, would y'all have any sway on getting these React peer deps approved?

Try react-credit-cards-2 mentioned at #115

Using this fork really doesn't make sense when it could be easily done so in the main package... Not to mention the community types for the official package.

SeanCassiere avatar Sep 29 '22 16:09 SeanCassiere

Looks like the maintainers of this package are inactive for quite some time now. Anyone, possibly, getting in touch with them to notify them will be of great help.

Of course, a separate spin-up repo with new maintainers will be great. But considering the popularity and contribution on this original project, it seems more important to get the original authors back online. They then can select new maintainers

waleedshkt avatar Dec 18 '22 14:12 waleedshkt