Amaresh S M comments

Results 43 comments of


                                            Amaresh  S M

chore: add node v18 to test workflow

Please approve test workflows

No such label 'done hook' for WebpackLogger.timeEnd()

@valscion The error message seems to be from Webpack logger. Can you pls brief what kind fix is expected here?.

Future of ecmaFeatures.globalReturn

Is it good to go now?

Docs: Add a Troubleshooting page

> I would like to incorporate a troubleshooting section, for sure. I'm not sure a FAQ is all that useful at this point (I'd like to remove most of what's...

docs: show red underlines in examples in rules docs

nice 🎉

Docs: flat config `files` / `ignores` function

I guess the docs need to be updated with the example. `files` and `ignores` can take functions also. ``` files - An array of glob patterns indicating the files that...

docs: [WIP] other way to fix no-js dark theme

> It looks like this PR is preferred over #18071? Can we close #18071 and mark this PR as ready for review? Yes, #18071 is closed. This is not ready...

docs: [WIP] other way to fix no-js dark theme

> @harish-sethuraman please don't just remove the "stale" label, we need to know why it's not stale. In this case, we should follow up with @amareshsm to see if he's...

Docs: Some dark mode text styles missing when JavaScript is disabled

The details addressing the issue are included in [this comment](https://github.com/eslint/eslint/pull/18071/files#r1477012281). I've outlined two methods that I'm aware of to resolve the problem. Feel free to inform me if there are...

Rule Change: extend complexity rule to count optional chaining and default parameters/values

I don't think optional chaining and parameters will increase the cyclomatic complexity of the code ``` function a(x) { return x?.a?.b?.c?.d?.e?.f; } ``` This code doesn't have control flow statements...