next-intl icon indicating copy to clipboard operation
next-intl copied to clipboard

fix: replaceAll changed to replace to support older browser versions

Open MichalMoravik opened this issue 1 year ago • 4 comments

Fixes #884

MichalMoravik avatar Feb 25 '24 23:02 MichalMoravik

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-intl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2024 9:18am
next-intl-example-app-router ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2024 9:18am

vercel[bot] avatar Feb 25 '24 23:02 vercel[bot]

@MichalMoravik is attempting to deploy a commit to the next-intl Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 25 '24 23:02 vercel[bot]

@amannn I replied in the issue. Thank you!!

MichalMoravik avatar Feb 26 '24 08:02 MichalMoravik

Thanks! Yep, as mentioned I'd be ok with this change as long as the bundle size doesn't grow. Can you fix the invalid regex?

amannn avatar Feb 28 '24 10:02 amannn

Hey @amannn, sorry for getting back so late. I just changed .replaceAll to .replace again after new updates. Can you check if everything is correct and let me know if this would be possible? Thanks!

MichalMoravik avatar Mar 13 '24 21:03 MichalMoravik