Jan Amann

> Allow passing regex literal instead of a string to `RegExp()` Can you elaborate how that would work?

So this is where we read the `subjectPattern` from the user: https://github.com/amannn/action-semantic-pull-request/blob/67cbd7a15a6eeea0c3a0dffff4768fa5653de05c/src/parseConfig.js#L26 … and here we construct the regex based on it: https://github.com/amannn/action-semantic-pull-request/blob/67cbd7a15a6eeea0c3a0dffff4768fa5653de05c/src/validatePrTitle.js#L123 I understand that we could accept another...

Hmm, I see. I guess it could be a reasonable change nonetheless. If you're up to testing this a bit further, feel free to open a PR with the change!...

Yeah, it's a bit unfortunate that this library has to [call `useSearchParams` in the provider](https://github.com/amannn/next-query-params/blob/a0472ff80e5e71c42a2d8547bcc20ad7d7c2b814/packages/next-query-params/src/NextAdapterApp.tsx#L14C24-L14C39), which generally means a rather top-level component in your app. That turned out to not...

I'm currently using this approach in Storybook which seems to work: ```js Cypress.on('window:before:load', window => { const originalFetch = window.fetch; window.fetch = (request, ...rest) => { const url = typeof...

Hey, thanks for the report! I agree, we could definitely support `numberingSystem` and `style`. As for `numeric` I'm a bit hesitant though, as it can lead to issues when values...

Sounds good, thanks for the feedback!

@lmac-1 I'll merge this in the current form, as I believe this is already quite an improvement and so that I can stack proposed docs from https://github.com/amannn/next-intl/pull/1017 on top of...

> I guess my only other comment would be perhaps the App Router example should be updated to match the new getting started steps? That's a great point, yes! I've...

@AhmedBaset Yep, that's of course correct—thanks for the feedback! The statement only applies to using a single language, I've changed it accordingly above.