Jan Amann
Jan Amann
Sorry, I don't know what this is about.
Superseded by https://github.com/amannn/next-intl/pull/1115
@ScreamZ shared his implementation here: https://github.com/amannn/next-intl/discussions/1170. Might be worth checking that out when we continue with this PR. Also https://github.com/amannn/next-intl/pull/899 provides a potential implementation. For context, I didn't look further...
Hey @RomainGueffier, thank you so much for this PR! 🙏 I currently have quite a full schedule and need to prioritize a little bit. Just wanted to let you know...
Hey @RomainGueffier, I've finally found time to look into this, thank you for your patience! While reviewing the code, I've cleaned up some things along the way and added a...
Yep, seems like all tests pass on CI! 🙌 @RomainGueffier would you mind having another look from your side at the code to see if everything matches your understanding?
> I feel like my code is a bit noisy, maybe I could clarify it in dedicated functions ? I think for the time being it's ok. I'd eventually like...
@RomainGueffier A rewrite being triggered in this case is correct. But for the `/sitemap.xml` request the middleware shouldn't run in the first place, based on [the matcher config](https://next-intl-docs.vercel.app/docs/routing/middleware#matcher-config). I think...
Thanks for this report, that's a great point! I wonder if `next-intl` could automatically do the right thing here, Next.js is certainly capable of that. This would need some further...
@fkapsahili Absolutely if you're interested, always a pleasure! 🙌