action-semantic-pull-request icon indicating copy to clipboard operation
action-semantic-pull-request copied to clipboard

Is there any way to control the title of RevertCommit

Open ccxhwmy opened this issue 2 years ago • 2 comments

Recently I'm trying to replace Semantic Pull Requests with action-semantic-pull-request, Semantic Pull Requests has config like allowRevertCommits, but I don't know how use action-semantic-pull-request to achieve the same effect, I hope action-semantic-pull-request to support tile like: Revert "feat(xxx): xxx".

ccxhwmy avatar Jul 15 '22 06:07 ccxhwmy

I found revertPattern: /^Revert\s"([\s\S]*)"\s*This reverts commit (\w*)\./, in https://github.com/amannn/action-semantic-pull-request/blob/main/dist/index.js, it seems like action-semantic-pull-request support RevertCommit like Revert "feat(test): aaaa" This reverts commit aaaaaaa., but it does not effective. image image

ccxhwmy avatar Jul 15 '22 06:07 ccxhwmy

Looks like this happens because the type is checked first and throws if it fails the check: https://github.com/amannn/action-semantic-pull-request/blob/47b15d52c5c30e94a17ec87eb8dd51ff5221fed9/src/validatePrTitle.js#L58-L62

frolic avatar Oct 15 '23 14:10 frolic