google-meet-bot icon indicating copy to clipboard operation
google-meet-bot copied to clipboard

Codebase contains hard-coded links.

Open arffsaad opened this issue 2 years ago • 6 comments

After inspecting the codebase, a few explicit references to the dev's filesystem is discovered. some contains dirs such as /home/aman/Documents

This can cause a lot of difficulties for people who try to use this in their own environment.

However this may not be the case for docker-based. I am not sure about it. But for linux setup, I'm having difficulties due to these.

arffsaad avatar Jul 04 '22 06:07 arffsaad

Hi! I'd like to help out on this issue. Can you assign it to me? I've already cloned the repo and made some changes for you to review.

LucasRochaAbraao avatar Oct 21 '22 11:10 LucasRochaAbraao

sure you can

amangupta0709 avatar Dec 07 '22 21:12 amangupta0709

Hi, sorry for the delay. I have a change but can't open a pull request. When running git push -u origin head from my local branch hard-coded-links I get this error:

ERROR: Permission to amangupta0709/google-meet-bot.git denied to LucasRochaAbraao.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

LucasRochaAbraao avatar Jan 08 '23 20:01 LucasRochaAbraao

Hi, sorry for the delay. I have a change but can't open a pull request. When running git push -u origin head from my local branch hard-coded-links I get this error:

ERROR: Permission to amangupta0709/google-meet-bot.git denied to LucasRochaAbraao.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Hi,

You have to fork this repo and make a new branch in that repo, make the code changes and then open a PR from the forked repo to the this repo

amangupta0709 avatar Jan 09 '23 07:01 amangupta0709

@LucasRochaAbraao were you able to raise PR for this issue, I assume a fix for this looks like "{current_dir}/djangobot/botserver/meetbot.py" which will work within docker as well as well as local runserver.

LEvinson2504 avatar May 21 '23 11:05 LEvinson2504

Is it still active and not completed?

If so I would like to contribute

VigneshRamanathan101 avatar Jul 03 '23 09:07 VigneshRamanathan101