sp.wack

Results 151 comments of sp.wack

> Tried this locally, seems to work great! Will merge when it's ready @rbren What have I missed that needs to be implemented before it is ready?

@rbren Those checks are regarding the i18n placeholder value for the language input which does not exist. Previously, the settings modal component was using a `` and was not set....

@Sparkier In `SettingsForm.test.tsx`, line 12, you can change the `render(...)` method with the `renderWithProviders(...)` method from `test-utils` to resolve the errors thrown during testing. You can do the same for...

I tried pushing the changes to this branch myself, but I am not entirely familiar with how branch sharing works on GitHub (I work on BitBucket)

I am confused on the requirements of the download feature. What exactly do we want the user to download and what format should the expect it in? If the workspace...

> I am actually imagining something like the VSCode front-end, where the user could just right-click, select one file, and then download. Or the user could select an entire folder,...

@xingyaoww Yes I see now, that makes much more sense. On the topic of VSCode Web, it seems like it is just VSCode, on the web. I'm not sure if...

For images and videos it may be as simple as rendering an `img` or `video` element given the extension/path.

Until there is any other better suggestion, I'll go ahead and test/implement typing effect as previous (albeit slower 😔)