Aman Srivastava

Results 71 comments of Aman Srivastava

hey @BigMichi1 can i work on this?

I'd like to contribute to this issue. @superstar54 It seems `WorkflowFactory `currently only accepts `WorkChain `and `WorkFunction`, so `WorkGraph `entry points fail type checks.

thanks @superstar54 for your reply!! One idea is to allow any class inheriting from Process and let plugins mark their workflows via a simple attribute/protocol (e.g., `is_workflow = True`).

Thanks for the clarification, checking the associated `ProcessNode `sounds like a clean and backward-compatible approach, since `WorkflowNode `already represents the class of workflow processes.

@superstar54 ``` node_class = getattr(entry_point, "node_class", None) if node_class is not None and issubclass(node_class, WorkflowNode): return entry_point ``` placed just before the `InvalidEntryPointTypeError `is raised. If this approach matches what...

@mbercx i have applied the changes. Please let me know if anything else is needed.

Thanks for the guidance! @leofang I have now implemented the changes! please let me know if any further adjustments are needed.

@ricardoV94 it would be really helpful if you could review the changes!