luxon-business-days icon indicating copy to clipboard operation
luxon-business-days copied to clipboard

Typescript support

Open aletfa opened this issue 3 years ago • 10 comments

Please implement the @types/luxon-business-days in order to work with typescript, like the main library 👌

aletfa avatar Jun 09 '21 13:06 aletfa

https://github.com/moment/luxon/issues/228 Looks like there is a 3rd party that provides the types for Luxon.

Are you requesting that I submit types into DefinitelyTyped?

amaidah avatar Jul 26 '21 22:07 amaidah

I'd like to see types submitted to DefinitelyTyped. That would be a helpful addition for anyone using TypeScript, and some IDEs point you in that direction. For example, from Visual Studio Code: image

jkraft-s1a avatar Aug 26 '21 19:08 jkraft-s1a

+1

alexkates avatar Sep 26 '21 18:09 alexkates

It is currently more common to include the types in the repo instead of using DefinatelyTyped

wowczarczyk avatar Oct 25 '21 17:10 wowczarczyk

+1

sdc-wag avatar Nov 11 '21 09:11 sdc-wag

I will stick with moment-business-days until this is completed.

xinthose avatar Sep 13 '22 20:09 xinthose

+1

cwancy avatar Dec 04 '22 21:12 cwancy

image image

fdemello avatar Jul 12 '23 14:07 fdemello

I've submitted a PR to add typings https://github.com/DefinitelyTyped/DefinitelyTyped/pull/69446

bcbailey avatar Apr 25 '24 22:04 bcbailey

@types/luxon-business-days has been published

bcbailey-torus avatar May 02 '24 20:05 bcbailey-torus