Hidden Circuit (Tessellation crash)

[VulgarBear]

When circuit is hidden via shift-right click it causes other players who approach to crash. crash-2017-05-31_22.19.06-client.txt crash-2017-05-31_22.12.50-client.txt

[tofof]

Confirmed, saw this exact behavior in skyfactory 3 and now again in age of engineering. Happens to non-host players almost instantly upon a circuit being hidden by themselves or by the host.

What I find oddest is that it only happens from circuits with 'names' on them (e.g. a circuit that has been touched by an AND blueprint at some point in its history, even if now it's just blank). For that reason I suspect it's an SCM issue, not an MCMP issue ... but that's at least a pretty narrow code path already isolated.

---

(Crossposted to MC Multipart Issue #103)

Easily repeatable crash using super circuit maker:

1. Local multiplayer game
2. Place an SCM circuit in the world
3. With appropriate ingredients (stack of tiny redstone, stack of redstone torches), rightclick the 'AND' blueprint from SCM onto the circuit.
4. Shift-rightclick the circuit with the SCM screwdriver to 'flip it over' (hide it).
5. Immediately observe a crash in any connected clients (that are nearby), but not usually the host.
   (Assuming the host didn't crash...)
6. Clients now also crash on login when trying to connect near an area where there's a flipped circuit.

Doesn't matter if it's the client or the host that places or flips the circuit.

Observed in: Minecraft 1.10.2 MCMultiPart-1.4.0-universal SuperCircuitMaker-1.0.4 forge-1.10.2-12.18.3.2316 Skyfactory 3 modpack

Observed in: Minecraft 1.10.2 MCMultiPart-experimental-2.0.0_88-universal SuperCircuitMaker-1.0.4 forge-1.10.2-12.18.3.2511 Age of Engineering modpack

crash-2017-11-30_18.39.02-client.txt

May relate to optifine, can't repro without it but trivially with it. :/ No mods loaded other than optifine, mcmp, and scm for the crashes below.

crash-2017-11-30_19.38.53-client.txt crash-2017-11-30_19.31.21-client.txt crash-2017-11-30_19.38.22-client.txt