amadeus-node icon indicating copy to clipboard operation
amadeus-node copied to clipboard

Typescript Types

Open lifeofdubem opened this issue 4 years ago • 6 comments

Description

This package is missing TypeScript Types defination

lifeofdubem avatar May 22 '20 20:05 lifeofdubem

Hello @lifeofdubem ,

Thank you for your interest in the Amadeus For Developers Node SDK.

At this moment, we do not support TypeScript and I shall mark this as a low-priority enhancement. Having said that, we happily accept any contributions from the open-source community and would be delighted to help, if you're interested in contributing to the SDK with this. The Contributor's Guide can be a good resource to start from.

akshitsingla avatar May 31 '20 14:05 akshitsingla

Hi! I just wanted to leave this as a note here. Since there is a Swagger spec for all (AFAIK) Amadeus APIs, one can codegen TypeScript types.

https://github.com/manifoldco/swagger-to-ts

hasparus avatar Jun 10 '20 15:06 hasparus

Thanks for your comment, @hasparus. Yes, we're considering consolidation of all our APIs into 1 swagger-spec, but no decision has been taken yet.

akshitsingla avatar Jun 10 '20 15:06 akshitsingla

+1 for TypeScript definitions.

@akshitsingla - is there any chance that we can get a consolidated OpenAPI / Swagger spec to build our own if this is a wontfix?

deldrid1 avatar Jul 07 '20 19:07 deldrid1

@akshitsingla would it help if I open a PR which migrates existing code to typescript with running tests but major any typings as a draft to move to typescript?

ireznik avatar Sep 22 '20 05:09 ireznik

+1 for TypeScript definitions.

@akshitsingla - is there any chance that we can get a consolidated OpenAPI / Swagger spec to build our own if this is a wontfix?

Hello! as you may have seen already, we have Open API specification repository since 2021. it is available per API :)

minjikarin avatar Jul 07 '22 11:07 minjikarin

This repository is not based on Typescript. For that reason, we are going to close this issue.

Juan Antonio

jabrena avatar Sep 01 '22 08:09 jabrena