amadeus-java

amadeus-java copied to clipboard

enums for Contact.DeviceType and Document.DocumentType

9

Fixes #199 ## Changes for this pull request Contact has deviceType as String; Document has documentType as String. Unfriendly to API consumer, as noted by remark in discord channel.

steve-donovan

## Description FlightOrder currently defines deviceType and documentType as String, they should really be enums for friendlier API I noticed someone in discord with the issue. as per spec ```...

steve-donovan

from: ``` compileJava { sourceCompatibility = "1.7" targetCompatibility = "1.7" } ``` to: ``` compileJava { sourceCompatibility = "1.8" targetCompatibility = "1.8" } ```

jabrena

Should return an empty array, empty list, or optional, instead of NULL

2

## Description As an example, the _FlightOfferSearch_ class has an array representing _Stops_ within a _Segment_. If there are no stops, the array is NULL and can cause an NPE...

steve-donovan

Add compilation support for Java 17

1

jabrena

Fixes #139 Replace by using [DatatypeConverter](https://docs.oracle.com/javaee/6/api/javax/xml/bind/DatatypeConverter.html) Reference: https://stackoverflow.com/questions/21904682/how-to-avoid-warning-for-the-base-64

xianqiliu

Reviewing the Unit Tests from the SDK, exist some cases where the current behaviour raise a NPE. ```java @Test public void testBuilderWithNullClientId() { assertThrows(NullPointerException.class, () -> Amadeus.builder(null, "secret").build()); } @Test...

jabrena

It is necessary to trace errors from fetch method: ```java private Request fetch(Request request) throws NetworkException { try { request.establishConnection(); write(request); } catch (IOException e) { throw new NetworkException(new Response(request));...

jabrena

## Description Currently, the Java SDK is generating bytecodes in Java 7 and it is a very very old Java version. According with the official Oracle documentation: ``` Oracle Java...

jabrena

## Description Review the usage of Base64 because it throws a warning in the Pipeline: ``` /home/runner/work/amadeus-java/amadeus-java/src/main/java/com/amadeus/travel/TripParser.java:9: warning: Base64 is internal proprietary API and may be removed in a future...

jabrena