sp_whoisactive icon indicating copy to clipboard operation
sp_whoisactive copied to clipboard
verified publisher icon amachanic

[FIX] Remove last_request_end_time predicate

Open amachanic opened this issue 4 years ago • 3 comments

I think this will fix various bugs. On the flip side, I have no idea what problems it will cause. This predicate was in place for about a decade and I can't remember why I put it in place.

amachanic avatar Nov 08 '21 19:11 amachanic

@amachanic not sure what happened here, but essentially the whole PR is a conflict. It might be easier to re-base and make the one change again.

erikdarlingdata avatar Nov 09 '21 22:11 erikdarlingdata

@amachanic not sure what happened here, but essentially the whole PR is a conflict. It might be easier to re-base and make the one change again.

I removed all of the tabs and switched to spaces.

amachanic avatar Nov 09 '21 22:11 amachanic

@amachanic not sure what happened here, but essentially the whole PR is a conflict. It might be easier to re-base and make the one change again.

I removed all of the tabs and switched to spaces.

Yeah, I caught that PR, but the diff wasn't loading here for a bit. Would you prefer to rebase with the spaces commit in place or just resolve this one?

erikdarlingdata avatar Nov 09 '21 22:11 erikdarlingdata