Amaan Qureshi

Results 406 comments of Amaan Qureshi

> @amaanq Luke should have fixed everything that you requested, could you review this and make sure everything looks good to you? One more thing, just the changes to the...

Rebase please @stsewd :slightly_smiling_face:

a lot of these are unnecessary imo, they don't help and add visual bloat

PR welcome, as long as it doesn't increase state count too much. Tree-Sitter is permissive on purpose for that reason

> also this ![image](https://private-user-images.githubusercontent.com/71744831/321679081-6bb33cc2-b0b2-47d2-8db5-15ed4780effa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI4ODUzNDksIm5iZiI6MTcxMjg4NTA0OSwicGF0aCI6Ii83MTc0NDgzMS8zMjE2NzkwODEtNmJiMzNjYzItYjBiMi00N2QyLThkYjUtMTVlZDQ3ODBlZmZhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDEyVDAxMjQwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY2YTA4ZWY0YzE2NWMzZjk0ZTRiNDFiNjlmNzk1MjQ3MjNhMTY2YTRlYzYyNGFmYmIxZmIyNTVkNjk3NGJjMGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.2Q2TJgYlZg6UjM3EP_2vlu1-k2BqkZ_cc1cgOosLPZc) > > edit: ignore the red dot its a mistake in the image this is an unclear example

~it should be now~ nvm this is the windows bug, not BSD, but really, I'd rather not introduce that macro *just* for *one* compiler on *one* OS, surely mingw can...

Tree-sitter requires C11 now and the scanner is no longer in c++, this is an issue with c++98 iirc so it's now a "wont fix, upgrade your compiler"

Un-hiding them would pollute the tree - that being said a mechanism to fetch hidden nodes might be useful upstream

updated, I hadn't even noticed the 4 quotes nor was it mentioned on the MS docs, but I found a different page that briefly mentioned it, thanks