Amaan Qureshi

Results 404 comments of Amaan Qureshi

Also a test or two could be useful if you don't mind adding that

thanks, sorry for taking so long to get to this.

I think this makes sense, though one thing to note is that the CLI relies on the mtime (modified time) of the parser OR scanner to trigger recompilation. Would you...

The issue is wasmtime-c-api isn't published on crates.io, see https://github.com/bytecodealliance/wasmtime/issues/7735 We will resolve this sometime the coming week most likely via either checking it out locally here as a submodule,...

Yeah, we're hoping that wasmtime will publish the c api to crates, Max has opened a PR for that that seems to be positively received, so let's hope for that!...

Wow, this is great! I will take a look later today

I'd almost guarantee it's an issue with the external scanner. I can take a look sometime this weekend, but if it's not reproducible with an upstream grammar I can't really...

I'm not getting a bus error, I'm getting the assertf failing Edit - nvm wasn't using 37f28b, I just don't get any failures here at all. Would a PR just...

yeah I'm on x86_64 Linux - platform shouldn't matter in this case imo

I'll close this out since it's difficult to reproduce, is more about the grammar's scanner, and I've PRed a fix/improvement to it anyways