Amaan Qureshi

Results 403 comments of Amaan Qureshi

can't reproduce in a js file - a reproducer w/ steps would be useful

right...updating it to the latest commit = updating the plugin

Hm, taking a look at that and the go grammar - I would say the opposite, that import_spec_list shouldn't exist just like with var_spec, would that consistency be good for...

Hm, maybe the plugin should account for nodes with repetitions in them - though I can imagine that's much more complicated than adding a rule here. Though I'll be honest,...

@segevfiner @verhovsky do check out the changes I've made now, I mostly ported over #163 and tidied some bits up

I partially disagree - rules shouldn't be named like that, it makes no sense and it would be correct to abstract those rules to a node containing the special character...

Btw, do we want to switch to napi still? I'd like to do that upstream and here if that proves to be very beneficial, I forgot what exactly the benefits...

Agreed, it's just massively breaking as all grammars will need to regenerate their bindings to have the napi one instead of nan

I'm nearing the finish line for this PR (pretty much just LookaheadIterator left) - but that being said, I have no idea why CI is failing, it does require rebuilding...

LookaheadIterator is done - the only functions that are available upstream but not used here are the following: ``` ts_language_next_state( ts_language_state_count( ts_language_symbol_for_name( ts_lookahead_iterator_language( ts_node_eq( ts_node_is_null( ts_node_language( ts_parser_cancellation_flag( ts_parser_language( ts_parser_parse_string( ts_parser_parse_string_encoding(...