Alexey Stukalov
Alexey Stukalov
> I applied all your suggestions. Is there anything else I have to fix? @MommaWatasu Thank you for adjusting the PR! We are getting close to be able to merge,...
@aaronpeikert Sure, that would be great! I can help you if you need my review.
It is a nice plan! Some comments: 1. *StatsAPI.jl* support could be implemented in phases. We can classify the items according to these phases * The phase 1 would be...
@lgatto I've added 2 unit tests with shuffled colData that fail without the fix.
@cvanderaa @lgatto Could you please take a look at the PR -- I have tried to address your code review comments? Thank you!
One other way to solve this is to support `implied`, `observed` etc to be anonymous functions, i.e.. ```julia Sem(dataframe, @StanGraph(...), observed = SemObservedMissing, specification = (def, obs_vars) -> RAMMatrices(def, observed_vars...
I've rebased the PR after the #253 got merged. @Maximilian-Stefan-Ernst I have also noticed that you have implemented #246. I am not sure I understand what was exactly the reason...
@Maximilian-Stefan-Ernst @brandmaier @aaronpeikert In the recent months the merging of some of the changes from my staging branch (PR #193) into the main branch was dormant. But I would be...
Thank you for the contribution! I think it would be useful addition. I have not reviewed your PR in the detail, but there are some things that I have noticed:...
> Regarding your first point, isn’t that breaking? And how should I deal with the 4 variants of the adjusted mutual information? Have one symbol for each? (And another that’s...