Results 163 comments of alyssawilk

Also, looks to me like onStatus is returning the reason phrase, not the status code? rename or fix is in order?

is it just the single integer? looks like isHttp11 also refers to headers, as does contentLength and possibly others (I stopped at n=2). I think it'd be safer to keep...

This needs a main merge but in the meantime @lizan can you please take a look?

reopening because it's not yet regression-proof "Once this is done you should be able to remove your extension from the exempt extensions in [test/per_file_coverage.sh](https://github.com/envoyproxy/envoy/blob/master/test/per_file_coverage.sh)"

Given no one else has complained (so I think this is a pretty narrow use case) would you be Ok with me going with (3), hidden runtime option y'all could...

The problem with this is we can't clearly designate some matchers as for TCP and others for HTTP. Largely I think if you want to use ALPN, you should dup...

hm, CI looks wedged. can you do a main merge - maybe sorting current.yaml will fix?

We already have envoy per-route config https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route.proto I think changing buffer limits makes more sense there than in a filter many may not use.

something like that yes. cc @envoyproxy/api-shepherds

yeah I think we're going to have to hook some of those up (e.g. flow control really important) but I think we can go through function by function as we're...