falcon-apispec icon indicating copy to clipboard operation
falcon-apispec copied to clipboard

Fixed invalid methods error in falcon 3

Open vuonglv1612 opened this issue 3 years ago • 6 comments

From falcon 3+, some methods was added which aren't in OpenAPI v3 valid methods. We can filter invalid methods before add to mapping

Ref: https://github.com/alysivji/falcon-apispec/issues/31

vuonglv1612 avatar Jun 13 '21 05:06 vuonglv1612

Codecov Report

Merging #32 (e81e569) into master (a5e665e) will decrease coverage by 2.12%. The diff coverage is 100.00%.

:exclamation: Current head e81e569 differs from pull request most recent head 13734f0. Consider uploading reports for the commit 13734f0 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #32      +/-   ##
===========================================
- Coverage   100.00%   97.87%   -2.13%     
===========================================
  Files            3        3              
  Lines           40       47       +7     
===========================================
+ Hits            40       46       +6     
- Misses           0        1       +1     
Impacted Files Coverage Δ
falcon_apispec/falcon_plugin.py 97.72% <100.00%> (-2.28%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a5e665e...13734f0. Read the comment docs.

codecov-commenter avatar Jun 13 '21 05:06 codecov-commenter

hey @aslantar when you have time could you please merge this PR? thank you so much

Javlopez avatar Feb 28 '22 18:02 Javlopez

hi @Javlopez, I approved already, but I'm not eligible to merge. @alysivji can you help?

aslantar avatar Feb 28 '22 19:02 aslantar

Hi @alysivji can you help us to merge the PR?, thank you so much

Javlopez avatar Mar 08 '22 17:03 Javlopez

@alysivji Can this be merged?

adammkelly avatar Sep 27 '22 17:09 adammkelly

@alysivji It's been basically an year since the solution to this critical bug has been provided. Any reason the PR is not being merged?

AndreasBBS avatar Dec 05 '22 19:12 AndreasBBS