Alastair Murray comments

Results 27 comments of


                                            Alastair Murray

Consider to add a new error code for `urVirtualMemMap` when the VA is already mapped

@steffenlarsen Do you have thoughts on this? Is a new error code for this situation okay, and does it seem like all adapters could accurately provide it?

[CMake] Unified runtime update fails.

Now that the Unified Runtime code has been moved into this repo FetchContent is no longer used, so this can no longer happen.

Unable to point to a static, offline copy of dependencies

Note this is the same use-case, but with different suggestions, as #2494.

Consider changing `urProgramGetFunctionPointer` to `urProgramQueryHasKernel`

* Is only implementable by OpenCL adapter, and even then only with extensions. * Possible that this could still represent an important use-case, e.g. on FPGA, needs to be investigated....

Inconsistent behavior between UR_DEVICE_INFO_UUID vs UR_DEVICE_INFO_PCI_ADDRESS

Thank you for the report! Clearly urinfo should not be printing raw output like that, perhaps the type of `UR_DEVICE_INFO_UUID` should be `uint8_t[]` (this is what it is in Level...

Inconsistent behavior between UR_DEVICE_INFO_UUID vs UR_DEVICE_INFO_PCI_ADDRESS

OpenCL has the `cl_khr_pci_bus_info` extension, but OpenCL can be implemented on non-PCI devices, e.g. CPUs, so there will always be situations where this extension is not provided. Same situation as...

Add clSetCommandQueueProperty test

We also never implemented this entry point and I'm not aware of that ever causing problems. I understand that is not consistent with the specification definition of deprecation though.