PhoneVR
PhoneVR copied to clipboard
alvr-org
Implement gvr/noGvr variants
📷 Screenshots of tests:
📱gvr: emulator-5554 - 11
🔧 ALVRActivityTest_saveDeviceScreenBitmap
🔧 ALVRActivityTest_saveDeviceScreenBitmap_LookingDown
🔧 ALVRActivityTest_saveDeviceScreenBitmap_LookingFrontDown
🔧 ALVRActivityTest_saveDeviceScreenBitmap_Popup
🔧 InitActivityTest_saveDeviceScreenBitmap
🔧 MainActivityTest_saveDeviceScreenBitmap
🔧 SettingsActivityTest_saveDeviceScreenBitmap
🔧 view-op-error-1
📱noGvr: emulator-5554 - 11
🔧 ALVRActivityTest_saveDeviceScreenBitmap
🔧 ALVRActivityTest_saveDeviceScreenBitmap_LookingDown
🔧 ALVRActivityTest_saveDeviceScreenBitmap_LookingFrontDown
🔧 ALVRActivityTest_saveDeviceScreenBitmap_Popup
🔧 InitActivityTest_saveDeviceScreenBitmap
🔧 view-op-error-1
For commit c2dd013a3bf13776f740347c540f87708945e1cd
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
that can be done easier when variants are separated like this (just need to delete some folders and change very few lines in build script) in a follow-up commit :P
To clarify, this PR also includes fixes for building with newer Android Gradle Plugin (including moving from synthetic binding to view binding) and removing implicit dependencies on resources by GVR SDK, so it's easier to just merge this and drop support afterwards as I already did the untangling work.
To clarify, this PR also includes fixes for building with newer Android Gradle Plugin (including moving from synthetic binding to view binding) and removing implicit dependencies on resources by GVR SDK, so it's easier to just merge this and drop support afterwards as I already did the untangling work.
Can you look at the CI erros and try fixing them ? There seems to some errors
@nift4 Ping me when you can E2E Test to run, i.e after you are done with all your changes
@ShootingKing-AM The tests all succeeded and the comment text + images was successfully generated, it just wasn't posted due to some permission error, can you check why or merge?
The E2E test run is https://github.com/alvr-org/PhoneVR/actions/runs/10651245975/job/29523607769. Ok-to-run lauches a seprate github action run the E2E test to circumvent some github limitations (Goto PhoneVR Repo->Actions->CI and the e2e tests are with the name ok-to-test-command). The error is in the attachments of Action Summary.
The error is given there. Am guessing, since we are using the same apk name, and same emulator instance, you need to remove the already installed gvr apk before trying to install and test noGvr apk onto emulator.
Exception thrown during onBeforeAll invocation of plugin AndroidTestApkInstallerPlugin: ErrorName: UNKNOWN
NameSpace: DdmlibAndroidDeviceController
ErrorCode: 1
ErrorType: TEST
Message: Failed to install split APK(s): [/Users/runner/work/PhoneVR/PhoneVR/code/mobile/android/PhoneVR/app/build/outputs/apk/noGvr/debug/PhoneVR-v2.0.0-beta-noGvr-debug.apk]
Failed to install split APK(s): [/Users/runner/work/PhoneVR/PhoneVR/code/mobile/android/PhoneVR/app/build/outputs/apk/noGvr/debug/PhoneVR-v2.0.0-beta-noGvr-debug.apk]
'package install-create -r -t -S 107735948' returns error 'Unknown failure: cmd: Can't find service: package'
com.android.ddmlib.InstallException: 'package install-create -r -t -S 107735948' returns error 'Unknown failure: cmd: Can't find service: package'
at com.android.ddmlib.SplitApkInstallerBase.createMultiInstallSession(SplitApkInstallerBase.java:124)
at com.android.ddmlib.SplitApkInstaller.install(SplitApkInstaller.java:68)
at com.android.ddmlib.IDeviceSharedImpl.installPackages(IDeviceSharedImpl.java:395)
at com.android.ddmlib.internal.DeviceImpl.lambda$installPackages$36(DeviceImpl.java:1492)
at com.android.ddmlib.internal.DeviceImpl.logRun3(DeviceImpl.java:1834)
at com.android.ddmlib.internal.DeviceImpl.installPackages(DeviceImpl.java:1489)
at com.android.ddmlib.internal.DeviceImpl.lambda$installPackages$37(DeviceImpl.java:1504)
at com.android.ddmlib.internal.DeviceImpl.logRun3(DeviceImpl.java:1834)
at com.android.ddmlib.internal.DeviceImpl.installPackages(DeviceImpl.java:1500)
at com.android.tools.utp.plugins.deviceprovider.ddmlib.DdmlibAndroidDevice.installPackages(DdmlibAndroidDevice.kt:74)
at com.android.tools.utp.plugins.deviceprovider.ddmlib.DdmlibAndroidDeviceController$executeAsync$deferred$1.invokeSuspend(DdmlibAndroidDeviceController.kt:254)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:570)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:749)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:677)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:664)
service package not available would mean the emulator hasn't finished booting or has crashed, I believe. It's also weird cuz tests succeeded in my physical device and in GitHub CI of my fork
This is kinda weird i just merged my #375 there were no permission issues there Oo There seems to be 2 issues here one with CI actions one with noGvr
This is kinda weird i just merged my #375 there were no permission issues there Oo There seems to be 2 issues here one with CI actions one with noGvr
CI Issues are resolved in #375 and https://github.com/EnricoMi/publish-unit-test-result-action/issues/620
Applause for this huge and complex work is definitely warranted 🎉 Hopefully you keep contributing more to the code base 😄