ALVR icon indicating copy to clipboard operation
ALVR copied to clipboard

Linux vrcompositor wrapper cleanup

Open ckiee opened this issue 3 years ago • 3 comments

This issue is based off of https://github.com/alvr-org/ALVR/issues/269#issuecomment-843387487.

Currently, when ALVR starts on Linux the launcher moves some SteamVR binaries around to wrap vrcompositor in order to activate the Vulkan layer; this works fine until the user would like to use a different HMD which is supported by SteamVR without ALVR. (e.g. the Valve Index)

Right now, the user has to manually clean up after ALVR in order to use SteamVR once again.

ckiee avatar May 18 '21 17:05 ckiee

We have 3 solutions: cleanup on start, celanup on exit or compatibility

cleanup on start

Restore original steamvr install as soon as vrcompositor is started, this prevents a crash to leave a bad state. This has the disadvantages of making the launcher essential, breaking restart forever, and launcher still has to manage when the link already exists

cleanup on exit

I don't know exactly when the move would be made, same disadvantages as cleanup on start, I don't advise this solution

compatibility

Make it possible to use the wrapper even outside of ALVR, this probably requires many fixes and we must ensure it doesn't introduce a penalty in the non-ALVR use case. Advantages is that it is more robust Disadvantages are that it is harder to implement and to test

xytovl avatar May 18 '21 18:05 xytovl

Okayyy, maybe this isn't a very good first issue.

ckiee avatar May 19 '21 09:05 ckiee