ALVR icon indicating copy to clipboard operation
ALVR copied to clipboard

Fix: fixup sliding textbox inputs not saving value

Open Astyyyyy opened this issue 1 month ago • 3 comments

ok actually works this time, and properly tested it all with no issues that i can notice, seperated the textbox response calls to be inside the gui_type instead as union seemed to be messing it up

Astyyyyy avatar Nov 06 '25 09:11 Astyyyyy

I've read the code but I don't quite understand what changes functionally in this PR. Maybe you've duplicated the code and matched and take()n self.editing_value instead of using the reference editing_value_mut. Also you did not use .union(), maybe that was the source of the issue?

zmerp avatar Nov 07 '25 00:11 zmerp

the union is part of the issue, but just removing it isn't enough, and i have it duplicated because with the new ui changes its not using the sliders inbuilt textbox anymore, its a seperate one that gets created which would never get focused with old logic.

im not amazing at code so i dont know a good way of combining both into one response call if you can, and for not using the reference editing_value_mut i just dont know how rusts borrow system really works, if you have a better way you want it done just let me know and ill adjust it.

Astyyyyy avatar Nov 07 '25 08:11 Astyyyyy

I wonder why the union was not working. Usually only one control receives one event at a time (if they don't overlap). The union shouldn't be the problem. Then at that point the two blocks don't need to be duplicated anymore. So that leaves nothing that I think actually changes in this PR. I should probably experiment myself

zmerp avatar Nov 07 '25 12:11 zmerp