timefhuman
timefhuman copied to clipboard
alvinwan
pm am parsing
I would like for the program to recognise the current time of day and if I specify a time before this without any other parameters such as 'today' or 'tomorrow'. I think the default should be it goes to tomorrow. For example, "Remind me at 1 pm" or "Set an alarm for 7 am" should default to tomorrow at 1 pm if the current time is 5 pm for example.
This is another minor bug but I would like to solve it. When the string '5 o'clock pm' is entered this results in a value error when the program tries to parse '5 o'clock' as an integer.
What do other people think of both these problems?
@umerhasan17 That sounds good. If you could file separate PRs (o'clock v. am/pm), I can take a look. The default for "Monday" is "next Monday," so what you said for am/pm would only make sense.
@alvinwan I created the PR for the simpler fix and working on the other one. Can you explain why the coverage drops because of the extra 3 lines? Thank you.
Hey @umerhasan17, nice work! The coveralls bot reply in your PR https://github.com/alvinwan/timefhuman/pull/13#issuecomment-587966547 provides a link timefhuman/categorize.py that shows which lines are not covered by tests.