extension icon indicating copy to clipboard operation
extension copied to clipboard

Include "Did you know?" when fact is present and show on 'back' of AmbassadorCard

Open itsjayway opened this issue 6 months ago â€ĸ 8 comments

Reference: https://github.com/alveusgg/extension/issues/325

Hey all, I'm back! This is an MVP of implementation. It's currently missing the tailwind 'flip' animation as of the current commits and I'll continue toward delivering that in this PR.

If this is sufficient to proceed, I'm looking for feedback in:

  • [ ] "Did you know? â„šī¸" placement on the 'front' of the card.
  • [ ] Card 'back' formatting
  • [ ] Implementation

https://github.com/user-attachments/assets/61e563e2-de38-4f56-a16a-77dc5d3d1abd

itsjayway avatar Jul 10 '25 07:07 itsjayway

👀 Thank you for working on this! I think I agree with a lot of the feedback that copilot is giving.

Instead of having it be a heading with an icon that you need to clip, perhaps we could do a peeking/peeling corner that the user can click on to flip the card over? And perhaps when they hover on that corner we show a tooltip to give context on clicking to flip?

And I think quite important to this is an actual flip animation rather than just conditionally switching the content, though it sounds like you already plan to work on that!

MattIPv4 avatar Jul 10 '25 14:07 MattIPv4

Currently the simplest way I could manage rendering the dogear. It should be possible to have the fold "bring more with it" via translate-x/y, but that would reveal the unclipped portion of the card.

https://github.com/user-attachments/assets/6e5d0be4-5034-4e81-8c63-324815223751

itsjayway avatar Jul 13 '25 04:07 itsjayway

That looks great -- I think with a shadow on that, and the tooltip, it should be just fine.

MattIPv4 avatar Jul 13 '25 16:07 MattIPv4

One other thought, I wonder if it'd be worth splitting AmbassadorCard.tsx into ambassador/card-front.tsx + ambassador/card-back.tsx + ambassador/card.tsx (and AmbassadorButton.tsx could also move to ambassador/button.tsx)?

MattIPv4 avatar Jul 13 '25 16:07 MattIPv4

👋 @itsjayway how're things going on this? Anything I can do to help get this landed?

MattIPv4 avatar Aug 02 '25 16:08 MattIPv4

hey @MattIPv4, got absolutely cooked at work the week following my commits here 😅 things should free up this week. I'll make an effort to progress/share blockers here, apologies again.

itsjayway avatar Aug 04 '25 06:08 itsjayway

@itsjayway how're things going, any progress update on here?

MattIPv4 avatar Sep 15 '25 20:09 MattIPv4

thanks for your patience @MattIPv4, life's butt-kicking again but here is another iteration for an MVP. something annoying to note with the Dogear's current state: if the image is hovered and expanded, when hovering the Dogear, the image contracts, 'evading' the cursor.

itsjayway avatar Sep 30 '25 04:09 itsjayway