pagePiling.js icon indicating copy to clipboard operation
pagePiling.js copied to clipboard

Horizontal swiping issue

Open milad-alizadeh opened this issue 9 years ago • 7 comments

I was trying to integrate owl carousel with pagePiling to create some horizontal slides within the vertical sections. I realized that pagePiling jumps to the next slide while even swiping horizontally. I looked at the plugin code and on line 773 we have this: if (Math.abs(touchStartY - touchEndY) > (container.height() / 100 * options.touchSensitivity)) { ... } container.height() returns 0 as all of its children are absolute positioned. That makes this statement always true and causes touch sensitivity to not work as intended. I got around this by setting the container height to 100% (or 100vh for IE9+) and that fixed my problem. Or may be we could use the height of one of the slides? Please do correct me if I'm making a mistake however I thought I should point this out.

milad-alizadeh avatar Jun 14 '15 20:06 milad-alizadeh

That's a nice point. Thanks for reporting it! Although I'm not quite sure that fixing it can solve the problem in the best way for you.

Pagepiling is only taking into consideration the Y position and it will slide up or down in any case. You can play with the touchSensitivity option to prevent sliding up or down on a very small change of the Y position, but still not the perfect way to do it.

I'll correct the issue with the height in the next few days. Thanks for it!

alvarotrigo avatar Jun 14 '15 21:06 alvarotrigo

Has this been fixed yet?

Sneakyp33t avatar Aug 19 '15 13:08 Sneakyp33t

@Sneakyp33t nop.

alvarotrigo avatar Aug 19 '15 13:08 alvarotrigo

Workaround.

In my design, I have galleries with touch enabled features that were conflicting with this plugin. A quick fix that I used was having a thumbnail that linked to the gallery in a lightbox that was called outside of the wrapper for pagepiling.

ghost avatar Oct 26 '15 18:10 ghost

Hi! Has this been fixed? @alvarotrigo

yanballas avatar Nov 20 '23 15:11 yanballas

@yanballas pagePiling.js is not actively maintained. I'd recommend you to switch to fullPage.js instead which is my main focus now :)

alvarotrigo avatar Nov 20 '23 15:11 alvarotrigo

@alvarotrigo Can I use fullPage.js for commercial production of a small website? I can't figure out the license and unfortunately I can't buy the paid version. If not, could you tell me how to solve the problem with horizontal swipe? Thank you.

yanballas avatar Nov 24 '23 12:11 yanballas