angular-fullpage icon indicating copy to clipboard operation
angular-fullpage copied to clipboard

Update to angular 9

Open obsd opened this issue 5 years ago • 3 comments

obsd avatar Jun 02 '20 06:06 obsd

Thanks for that @obsd ! One question tho, it seems you are removing the polyfills.ts file but then you keep including it on tsconfig.app.json. Is that correct?

  "files": [
    "test.ts",	    "main.ts",
    "**/*.spec.ts"	    "polyfills.ts"
  ],

alvarotrigo avatar Jun 02 '20 09:06 alvarotrigo

Thanks for that @obsd ! One question tho, it seems you are removing the polyfills.ts file but then you keep including it on tsconfig.app.json. Is that correct?

  "files": [
    "test.ts",	    "main.ts",
    "**/*.spec.ts"	    "polyfills.ts"
  ],

The remove is angular auto-upgrade, so probably we should remove it from ts config as well, do you want me to do it?

obsd avatar Jun 11 '20 19:06 obsd

That'd be great thanks! ;)

alvarotrigo avatar Jun 12 '20 11:06 alvarotrigo