investpy icon indicating copy to clipboard operation
investpy copied to clipboard

Create a file for people to add missing stocks in stocks.csv

Open markus080402 opened this issue 4 years ago • 5 comments

Hi!

People continuously report missing stocks in stocks.csv, see for example https://github.com/alvarobartt/investpy/issues/165 .

A solution to this could be to create a file in the investpy git repo where people can add missing stocks as they find them, with the correct format, so anyone can leverage this file and get the missing stocks.

@alvarobartt could you create such a file so we can add missing stocks?

markus080402 avatar Jan 29 '21 13:01 markus080402

Sure! @markus080402 Indeed that file is already open to edits 🤗

All the resources used by investpy are available at https://github.com/alvarobartt/investpy/tree/master/investpy/resources

Feel free to edit those files including the missing financial products! 👍🏻 Remember that you can also use the investpy.search_quotes() function to find the missing stocks, etc. More information on its usage is available at https://github.com/alvarobartt/investpy/wiki/investpy.search_quotes()

alvarobartt avatar Jan 29 '21 14:01 alvarobartt

Thanks @alvarobartt for the answer.

From what I understand, stocks.csv is generated by you and the closed source code of investpy, do you mean that users should manually add missing stocks to stocks.csv?

If so, it could be clean to keep that separate, hence let stocks.csv only contain stocks generated by your closed code, and then add a new file where users manually add missing stocks. What do you think?

Thanks and regards, Markus

markus080402 avatar Jan 29 '21 14:01 markus080402

A long time ago I thought of including a function per each search result from the investpy.search_quotes() function, so that users could dynamically modify those files and then suggesting them to create a PR with the missing data or something like that 😩 Anyway I did not come up with any solution I consider clean yet...

What you say anyway makes sense, I may create an extra file to include the manually curated list of missing stocks (or any other financial product) 🤗 BTW in the meantime, feel free to modify the original file including the stocks that are missing!

Another option is that I open source also the code for generating those files so that the content of those files can be collaborative, as currently, the script I use seems to have problems as there's a lot of missing information (mainly due to Investing.com indexing errors...) but I'll think of it! 👍🏻

alvarobartt avatar Jan 29 '21 14:01 alvarobartt

@alvarobartt thanks, please do add the extra file, it would make things a lot easier.

markus080402 avatar Jan 29 '21 15:01 markus080402

Hi. I added a commodity (Dutch TTF, line 68), but I don't see any changes. Do you need to confirm the change? Thank you very much!

MetalComm avatar Feb 25 '22 14:02 MetalComm