Alvaro Aleman
Alvaro Aleman
@sdif that is very odd, and with sinker it works? It also just does a delete: https://github.com/kubernetes/test-infra/blob/5ed7f971e5e68db90d749f9acd2f40e012792932/prow/cmd/sinker/main.go#L484
So far the assumption has been that this repo is fairly self-contained and that if we want to upgrade e.G. the go version, we can just do that. I wasn't...
If this is just about kubetest, what keeps us from just upgrading its go version?
I believe our statement to `is test-infra supported as a library` is no. Openshift has a [repo that heavily depends on test-infra](https://github.com/openshift/ci-tools) so we informally agreed on asking before removing...
/ok-to-test
/label tide/merge-method-squash
@ykakarap thanks for your work! Unfortunately, a 7k LOC PR is very time-consuming to review. Could you please try to de-duplicate the tests and run them against both versions, denoting...
> Could you please try to de-duplicate the tests and run them against both versions, denoting expected failures in the current approval plugin as applicable? Or alternatively, maybe one commit...
@Ressetkk idea sounds fine to me, feel free to pick this up. We will need to keep supporting the existing format though to not break ppl.