Alvaro Aleman

Yeah, should match what upstreams uses. Feel free to open a PR where you update it and reference the upstream source.

Unmarshaler decoder is here: https://github.com/kubernetes/kubernetes/blob/f02682c628c530219966a00ae002d799f0d813dc/vendor/github.com/json-iterator/go/reflect_marshaler.go#L201 Regex is here but it is documented as being overly permissive: https://github.com/kubernetes/kubernetes/blob/f02682c628c530219966a00ae002d799f0d813dc/staging/src/k8s.io/apimachinery/pkg/api/resource/quantity.go#L136 If it is an improvement over what we currently have, we should probably...

>> Can we add a test case as well? > Probably above my skill level. There isn't much of a point in merging a fix without a test, the next...

> ginkgo v1 and v2 have conflicting flags, so you can't import them both at the same time (see https://github.com/onsi/ginkgo/issues/875#issuecomment-1036350659). Thanks to @mboersma for pointing this out But we only...

@schrej the tests paniced but still passed: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_controller-runtime/1977/pull-controller-runtime-test-master/1559847725640454144

> FYI, it is possible to enable JUnit output without using the ginkgo cli. You can either do go test ./ -args -ginkgo.junit= or add some code like The issue...

> Which of the two options? -ginkgo.junit or adding some custom GenerateJUnitReport invocation? Either way, that sounds like a bug that should be reported. It was reported here, maybe it...

> Probably because we're currently importing ginkgo v1 in pkg/envtest/printer. But v2 is imported as `github.com/onsi/ginkgo/v2` or not?

> In summary, all projects depending on controller-runtime will have to update to ginkgo v2 after this is merged and released. This is really, really bad. Is there any way...

Okay, that is awesome. I have a really busy week atm, will try to look at this next week. If someone else has time for a first pass, that would...