Alvaro Aleman

Sorry, I missed the notifications here. So yeah, the next steps would be to get rid of all of it internally, which might also entail some breaking changes. There are...

Kind of torn here. Not having pprof is extremely annoying in production, but it definitely exposes sensitive information. @AlmogBaku what is the reason why you would prefer build tags over...

> Exposing this setting using a build tag is like having a “remote debugger” - possible, but should be allowed implicitly and temporary on production mode I actually disagree with...

This is likely because you have a handler that reacts to the service creation, and since it takes a moment for the event to arrive, it does so after the...

/help If 0 already has a meaning, maybe use a negative value for disabling?

> introduces WithLogConstructor and removed WithLogger but in practical it's very hard to use WithLogConstructor to inject fields like: Can you elaborate why that is hard and easier with this?...

@timonwong how about instead just adding the fields unconditionally, regardless of logConstructor being set or not? The new api this introduces is IMHO not great, from a users POV it...

sounds good to me

> Is this issue looking for help? I have a need for doing the client supporting subresources such as get pods/log Those are not CRUD subresources, see https://github.com/kubernetes-sigs/controller-runtime/issues/452 for that...

FWIW, we've build something like this as a `Reconciler` wrapper downstream: https://github.com/openshift/ci-tools/blob/e847c7d352263b7415732d4309c041d3afb8ab71/pkg/controller/util/request_coalescer.go#L13