Alvaro Aleman
Alvaro Aleman
/ok-to-test The change seems fine, could you add a test for this please?
> I could add a test, but looking at the proposed change I'm not quite sure what to test for? Well, that requests from the apps auth roundtripper get executed...
> But that isn't a request it's just creating a JWT using the PrivKey and AppID (https://docs.github.com/en/developers/apps/building-github-apps/authenticating-with-github-apps) which you then use to get the actual Token or did I misunderstand...
@nouseforaname this still isn't addressed so this will not actually work: https://github.com/kubernetes/test-infra/pull/24882#issuecomment-1111337997 /label tide/merge-method-squash
Conceptionally I am fine with this but not sure how easy it is to implement. The approval seems straight forward but before we can approve anything, we have to find...
Not sure if it is realistic to have this everywhere. You can use `managedFields` through something like [kubectl blame](https://github.com/knight42/kubectl-blame) or maybe even just check if the `kubectl.kubernetes.io/last-applied-configuration` is present if...
> Are the corrupted binaries deterministic? WDYM by that, if they are always corrupted in the same way? If yes, I think so but currently only have one sample lying...
> Is the corruption always on the ELF header? I _think_ so, I remember I got a couple of `cannot execute binary file: Exec format error` errors and rebuilding helped....
> Is your program a pure-Go binary or it uses cgo (i.e. whether it is internal linking or external linking)? Mine is pure go (i.E. `CGO_ENABLED=0`)
@cherrymui I haven't seen this before using go 1.18, so I guess it is new. I did some more experimenting and found out: * I can somewhat reliably reproduce this...