url-to-pdf-api
url-to-pdf-api copied to clipboard
alvarcarto
Updating puppeteer to support newer Chrome features
Recently I tried to render a page that uses the newish CSS aspect-ratio and the resulting screenshot doesn't recognize it. I suspect the reason is that this project is pinned to puppeteer v2 which predates Chrome support for aspect-ratio.
Puppeteer is currently on v19 and it looks like Chrome added support for aspect-ratio around the time Puppeteer v13 was released. I tried updating package.json to newer versions but the API in those newer versions has changed (in ways I have not studied closely yet) so the app errors out.
@kimmobrunfeldt if I create a PR to update the Puppeteer would you consider merging it?
@samuliasmala If for some reason the maintainers don't want to support newer Puppeteer my company would be open to maintaining a fork.
@samuliasmala If for some reason the maintainers don't want to support newer Puppeteer my company would be open to maintaining a fork.
If you do create a maintained fork please let us know 😄
@samuliasmala @PrimeDominus We just forked the repo: https://github.com/userevidence/url-to-pdf-api
if I create a PR to update the Puppeteer would you consider merging it?
We don't have the bandwidth to tackle this ourselves at the moment, but if anyone has time we'd certainly merge a PR.